snapcraft.yaml: comment out isa-riscv64-rva23#437
Merged
alfonsosanchezbeato merged 1 commit intocanonical:mainfrom Apr 23, 2026
Merged
Conversation
Comment out isa-riscv64-rva23 assumes. Our github build process will uncomment it only for riscv64 architecture. This is needed because snapd versions previous to 2.75 fail to install core26 if the flag is present, for any architecture. And in many cases the snapd present is the one from the debian package.
alfonsosanchezbeato
requested review from
Meulengracht,
Copilot and
valentindavid
There was a problem hiding this comment.
Pull request overview
Updates the snapcraft.yaml base snap metadata to avoid declaring an assumes capability that breaks installation on older snapd versions, while keeping a path for enabling it on riscv64 in CI.
Changes:
- Comments out the
isa-riscv64-rva23entry underassumes. - Adds an explanatory comment indicating CI will enable it for riscv64 builds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
valentindavid
approved these changes
Apr 23, 2026
Meulengracht
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment out isa-riscv64-rva23 assumes. Our github build process will uncomment it only for riscv64 architecture. This is needed because snapd versions previous to 2.75 fail to install core26 if the flag is present, for any architecture. And in many cases the snapd present is the one from the debian package.